[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: Search VBT in VBIOS

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19314 )

Change subject: drivers/intel/gma: Search VBT in VBIOS
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/19314/9/src/drivers/intel/gma/opregion.c
File src/drivers/intel/gma/opregion.c:

PS9, Line 41: 	/* Find VBIOS in legacy PCI ROM area */
            : 	if (IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT) &&
            : 		!locate_vbt_vbios((void *)0xc0000)) {
            : 		/* The following fields are already validated: */
            : 		optionrom_header_t *oprom = (optionrom_header_t *)0xc0000;
            : 		*vbt = (optionrom_vbt_t *)(oprom + oprom->vbt_offset);
            : 		return 0;
            : 	}
            : 	printk(BIOS_DEBUG,
            : 	       "VBIOS at 0xc0000 not found or invalid.\n");
            : 
            : 	/* Find PCI VBIOS to extract VBT */
            : 	dev = dev_find_slot(0, PCI_DEVFN(2, 0));
            : 	rom = pci_rom_probe(dev);
            : 
            : 	if (rom && !locate_vbt_vbios((void *)rom)) {
            : 		/* The following fields are already validated: */
            : 		optionrom_header_t *oprom = (optionrom_header_t *)rom;
            : 		*vbt = (optionrom_vbt_t *)(oprom + oprom->vbt_offset);
            : 		return 0;
            : 	}
            : 	printk(BIOS_DEBUG,
            : 	       "VBIOS for PCI 0:02:00 not found or invalid.\n");
> This is all for the case we have a VBIOS in CBFS, isn't it? Where
What's wrong with using  pci_rom_probe(dev); ?


-- 
To view, visit https://review.coreboot.org/19314
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f8bb494e7574978a6ff34984faebb94c513010
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes