[coreboot-gerrit] Change in coreboot[master]: uart: Fix bug in {uart8250, uart8250_mem, ns16550}_rx_byte f...

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19731 )

Change subject: uart: Fix bug in {uart8250, uart8250_mem, ns16550}_rx_byte functions
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19731/1/src/drivers/uart/uart8250io.c
File src/drivers/uart/uart8250io.c:

PS1, Line 65: i 
> Does using the pre-incrementing operator `--i` help?
Yes, but then I run into issues with checkpatch.pl.

ERROR: trailing statements should be on next line
#10: FILE: src/drivers/uart/uart8250io.c:65:
+	while (--i && !uart8250_can_rx_byte(base_port));


-- 
To view, visit https://review.coreboot.org/19731
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ff531a1e729e816764f1a071484c924dcb0f85
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at gmail.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes