[coreboot-gerrit] Change in coreboot[master]: nb/amd_fam10/mct_ddr3: Use common function to compute crc16 ...

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19732 )

Change subject: nb/amd_fam10/mct_ddr3: Use common function to compute crc16 checksum
......................................................................

nb/amd_fam10/mct_ddr3: Use common function to compute crc16 checksum

Change-Id: I730a8a150134cc1ef8fb3872728bb0586ac7b210
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
1 file changed, 3 insertions(+), 24 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/19732/1

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index 1ac91a1..bcc1134 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -42,6 +42,7 @@
 #include <cpu/x86/msr.h>
 #include <arch/acpi.h>
 #include <string.h>
+#include <device/dram/ddr3.h>
 #include "s3utils.h"
 
 static u8 ReconfigureDIMMspare_D(struct MCTStatStruc *pMCTstat,
@@ -8214,30 +8215,8 @@
  */
 uint8_t crcCheck(struct DCTStatStruc *pDCTstat, uint8_t dimm)
 {
-	u8 byte_use;
-	u8 Index;
-	u16 CRC;
-	u8 byte, i;
-
-	byte_use = pDCTstat->spd_data.spd_bytes[dimm][SPD_ByteUse];
-	if (byte_use & 0x80)
-		byte_use = 117;
-	else
-		byte_use = 126;
-
-	CRC = 0;
-	for (Index = 0; Index < byte_use; Index ++) {
-		byte = pDCTstat->spd_data.spd_bytes[dimm][Index];
-		CRC ^= byte << 8;
-		for (i = 0; i < 8; i++) {
-			if (CRC & 0x8000) {
-				CRC <<= 1;
-				CRC ^= 0x1021;
-			} else
-				CRC <<= 1;
-		}
-	}
-	return CRC == (pDCTstat->spd_data.spd_bytes[dimm][SPD_byte_127] << 8 | pDCTstat->spd_data.spd_bytes[dimm][SPD_byte_126]);
+	return spd_ddr3_calc_crc(pDCTstat->spd_data.spd_bytes[dimm],
+				sizeof(pDCTstat->spd_data.spd_bytes[dimm]));
 }
 
 int32_t abs(int32_t val)

-- 
To view, visit https://review.coreboot.org/19732
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I730a8a150134cc1ef8fb3872728bb0586ac7b210
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>