[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19693 )

Change subject: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/19693/2/src/soc/intel/apollolake/include/soc/lpc.h
File src/soc/intel/apollolake/include/soc/lpc.h:

Line 34: #define REG_IO_DECODE			0x80
> Add defines for the fields you are wanting to set?
I added the defines for decoding range.


https://review.coreboot.org/#/c/19693/2/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

Line 94: 		 * ComB Range 2F8h-2FFh [6:4]
> it might be helpful to note the bit selection for both. e.g. com a is bit 2
Done


-- 
To view, visit https://review.coreboot.org/19693
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7d0b54edd18acf793849aef352afbcaeb68b9
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes