[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Add flash probe callbacks to spi_ctrlr structure
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Wed May 17 06:41:13 CEST 2017
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19708 )
Change subject: drivers/spi: Add flash probe callbacks to spi_ctrlr structure
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/19708/6/src/drivers/spi/spi_flash.c
File src/drivers/spi/spi_flash.c:
PS6, Line 338: (try_generic_probe_first != true)
> Why not '!try_generic_probe_first'? (This is circumventing the C assumption
Okay, I will update this.
https://review.coreboot.org/#/c/19708/6/src/include/spi-generic.h
File src/include/spi-generic.h:
Line 132: bool (*try_generic_probe_first)(void);
> If you want const structures, yes. There's *1* implementation that relies o
^ That is correct.
https://review.coreboot.org/#/c/19708/6/src/soc/mediatek/mt8173/flash_controller.c
File src/soc/mediatek/mt8173/flash_controller.c:
Line 237: return 0;
> I think this part is no longer necessary today. It used to be that several
Oh okay, I will clean it up then.
https://review.coreboot.org/#/c/19708/6/src/soc/mediatek/mt8173/include/soc/spi.h
File src/soc/mediatek/mt8173/include/soc/spi.h:
Line 110: int mtk_spi_flash_probe(const struct spi_slave *spi, struct spi_flash *flash);
> nit: better in flash_controller.h?
Yes, that is right.
--
To view, visit https://review.coreboot.org/19708
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list