[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Correct I2C bus number for TPM

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed May 17 06:29:58 CEST 2017


Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19710 )

Change subject: mainboard/google/poppy: Correct I2C bus number for TPM
......................................................................


mainboard/google/poppy: Correct I2C bus number for TPM

TPM is on I2C bus 1. Fix that.

BUG=b:36265511

Change-Id: I7fb696ca7281a0c099dd325d794dd4551cf20a53
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
Reviewed-on: https://review.coreboot.org/19710
Reviewed-by: Nicolas Boichat <drinkcat at chromium.org>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Naresh Solanki <naresh.solanki at intel.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Naresh Solanki: Looks good to me, approved
  Aaron Durbin: Looks good to me, approved
  Nicolas Boichat: Looks good to me, but someone else must approve
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 58af8df..fee40cd 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -24,7 +24,7 @@
 
 config DRIVER_TPM_I2C_BUS
 	depends on POPPY_USE_I2C_TPM
-	default 0x4
+	default 0x1
 
 config DRIVER_TPM_I2C_ADDR
 	depends on POPPY_USE_I2C_TPM

-- 
To view, visit https://review.coreboot.org/19710
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fb696ca7281a0c099dd325d794dd4551cf20a53
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Nicolas Boichat <drinkcat at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list