[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: Update touchpad I2C timing

Duncan Laurie (Code Review) gerrit at coreboot.org
Wed May 17 04:10:52 CEST 2017


Duncan Laurie has uploaded a new change for review. ( https://review.coreboot.org/19727 )

Change subject: mb/google/eve: Update touchpad I2C timing
......................................................................

mb/google/eve: Update touchpad I2C timing

The touchpad frequency was still slightly above 400kHz so tweak
the timing values manually to get under the spec limit.

BUG=b:35583133
TEST=verified the bus frequency with a scope to be < 400kHz

Change-Id: I8bd071a8e15a791b7551ac256797e87abd6b5e5a
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/eve/devicetree.cb
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/19727/1

diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb
index 1305f9c..97ae3c7 100644
--- a/src/mainboard/google/eve/devicetree.cb
+++ b/src/mainboard/google/eve/devicetree.cb
@@ -182,8 +182,12 @@
 	register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8"
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 111,
-		.fall_time_ns = 41,
+		.speed_config[0] = {
+			.speed = I2C_SPEED_FAST,
+			.scl_lcnt = 186,
+			.scl_hcnt = 93,
+			.sda_hold = 36,
+		}
 	}"
 
 	# Audio

-- 
To view, visit https://review.coreboot.org/19727
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bd071a8e15a791b7551ac256797e87abd6b5e5a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>



More information about the coreboot-gerrit mailing list