[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: console: Panic on death

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19696 )

Change subject: ec/lenovo/h8: console: Panic on death
......................................................................


Patch Set 3: Code-Review-2

(1 comment)

https://review.coreboot.org/#/c/19696/3/src/console/die.c
File src/console/die.c:

PS3, Line 29: if (IS_ENABLED(CONFIG_EC_LENOVO_H8))
I really don't care for this.

2 alternative options:  make a weak function for panic that does nothing and override it for the h8.
Add a generic CONFIG_HAS_PANIC option to kconfig, and then call panic if that's enabled.

Enabling a platform specific call from generic code seems wrong.


-- 
To view, visit https://review.coreboot.org/19696
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes