[coreboot-gerrit] Change in coreboot[master]: rockchip: rk3399: remove the delay for enabling SSC
Caesar Wang (Code Review)
gerrit at coreboot.org
Wed May 17 02:44:26 CEST 2017
Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19699 )
Change subject: rockchip: rk3399: remove the delay for enabling SSC
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/19699/2//COMMIT_MSG
Commit Message:
PS2, Line 7: rockchip: rk339
> Please use `rockchip/rk3399` as prefix.
done
PS2, Line 9: deassert
> by deasserting?
done
PS2, Line 9: The hang was caused by deassert the reset before, it had been delayed 20us
: fixing the hang issue.
: So we can remove this delay for now.
> Please add a blank line between paragraphs.
done.
Thanks for reviewing.
--
To view, visit https://review.coreboot.org/19699
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list