[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Add MIPI driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19477 )

Change subject: rockchip/rk3399: Add MIPI driver
......................................................................


Patch Set 9:

(2 comments)

It's odd that T7 is required when the datasheet says the minimum allowed value is 0? But okay, whatever works...

https://review.coreboot.org/#/c/19477/9/src/soc/rockchip/rk3399/chip.h
File src/soc/rockchip/rk3399/chip.h:

Line 39: 	u32 panel_T6;
This only happens to be called T6 in the datasheet for this specific panel, but I don't think(?) that's a general MIPI term for this delay. So we should give it a more generic name like panel_display_on_delay (and maybe panel_video_mode_delay for T7).


https://review.coreboot.org/#/c/19477/9/src/soc/rockchip/rk3399/mipi.c
File src/soc/rockchip/rk3399/mipi.c:

Line 410: 	struct soc_rockchip_rk3399_config *conf = dev->chip_info;
We may want to make this driver common between different Rockchip SoCs at some point, so you shouldn't access the devicetree object directly here. Instead, just have the two delays as two integer parameters for the function.


-- 
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul at chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nickey.yang at rock-chips.com
Gerrit-HasComments: Yes