[coreboot-gerrit] Change in coreboot[master]: drivers/spi_flash: Pass in flash structure to fill in probe

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19705 )

Change subject: drivers/spi_flash: Pass in flash structure to fill in probe
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19705/3/src/drivers/spi/boot_device_rw_nommap.c
File src/drivers/spi/boot_device_rw_nommap.c:

Line 102: const struct spi_flash *boot_device_spi_flash(void)
> Why have a 'generic' boot_device_get_info() when it seems like you just nee
That is true. I will push another patchset with the change to add boot_device_spi_flash to cbfs_spi.c


-- 
To view, visit https://review.coreboot.org/19705
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6f1b403731466525c4690777d9b32ce778eb563
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes