[coreboot-gerrit] Change in coreboot[master]: drivers/spi_flash: Add page_size to struct spi_flash

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19704 )

Change subject: drivers/spi_flash: Add page_size to struct spi_flash
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19704/2/src/soc/intel/common/block/fast_spi/fast_spi_flash.c
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

Line 307: 	flash->page_size = 256;
> For the other spi flash controllers that have their own hardware probe they
Other two providers are:
1. src/southbridge/intel/common/spi.c
2. src/soc/mediatek/mt8173/flash_controller.c


In both the implementations, I did not find anything relevant to page_size. mt8173 mostly cares about the dma buf len. southbridge intel uses something called cntlr.databytes, but it does not look like a page size to me.


-- 
To view, visit https://review.coreboot.org/19704
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f83e52cb1041432b0b575a8ee3bd173cc038d1f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes