[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: enable MONITOR/MWAIT feature for GLK.

ColeX Nelson (Code Review) gerrit at coreboot.org
Tue May 16 21:36:00 CEST 2017


ColeX Nelson has uploaded a new change for review. ( https://review.coreboot.org/19718 )

Change subject: soc/intel/apollolake: enable MONITOR/MWAIT feature for GLK.
......................................................................

soc/intel/apollolake: enable MONITOR/MWAIT feature for GLK.

Make MONITOR/MWAIT the default for GLK.
This will support the intel_idle kernel driver.

Change-Id: If648c25a9b26c04b278dce4af241d439790288ca
Signed-off-by: Cole Nelson <colex.nelson at intel.com>
---
M src/soc/intel/apollolake/chip.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/19718/1

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 50a285e..09fddae 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -491,10 +491,12 @@
 
 	silconfig->LPSS_S0ixEnable = cfg->lpss_s0ix_enable;
 
+#if !IS_ENABLED(CONFIG_SOC_INTEL_GLK)
 	/* Disable monitor mwait since it is broken due to a hardware bug
-	 * without a fix
+	 * without a fix. Specific to apollolake.
 	 */
 	silconfig->MonitorMwaitEnable = 0;
+#endif
 
 	silconfig->SkipMpInit = 1;
 

-- 
To view, visit https://review.coreboot.org/19718
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If648c25a9b26c04b278dce4af241d439790288ca
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: ColeX Nelson <colex.nelson at intel.com>



More information about the coreboot-gerrit mailing list