[coreboot-gerrit] Change in coreboot[master]: lib/boot_device: Add API for getting boot device information

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19701 )

Change subject: lib/boot_device: Add API for getting boot device information
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19701/2/src/include/boot_device.h
File src/include/boot_device.h:

PS2, Line 66: void *
> shouldn't this be const void *? Should we be able to manipulate the structu
No, const void * makes sense. Caller should not be manipulating it.


-- 
To view, visit https://review.coreboot.org/19701
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia35fc275a2aacf1cf8a3080d5f0da5dc19284206
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes