[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: console: Panic on death

Patrick Rudolph (Code Review) gerrit at coreboot.org
Tue May 16 18:46:53 CEST 2017


Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19696

to look at the new patch set (#3).

Change subject: ec/lenovo/h8: console: Panic on death
......................................................................

ec/lenovo/h8: console: Panic on death

Call h8_panic to signal critical failure.

Guard some functions in romstage.
Move static functions to enable romstage guard.
Build h8.c in romstage, too.

Tested on Lenovo T500.
Tested on Lenovo X200.

Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/console/die.c
M src/ec/lenovo/h8/Makefile.inc
M src/ec/lenovo/h8/h8.c
3 files changed, 24 insertions(+), 16 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/19696/3
-- 
To view, visit https://review.coreboot.org/19696
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list