[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19693 )

Change subject: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19693/1//COMMIT_MSG
Commit Message:

PS1, Line 9: If there is an external 8250 UART, one needs to enable the appropriate
           : address ranges before console_init() is called so that the init sequence
           : can reach the external UART.
           : 
           : Furthermore FSPM needs different settings for an extern
> Please add a blank line between paragraphs.
Done


PS1, Line 13:  for an exter
> has to be adapted?
Done


https://review.coreboot.org/#/c/19693/1/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

PS1, Line 270: 	/
> Would it make sense to use else if () here so that if for any reason CONFIG
Sure, you are right. It's better to make it with else if().


-- 
To view, visit https://review.coreboot.org/19693
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7d0b54edd18acf793849aef352afbcaeb68b9
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes