[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Add MIPI driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19477 )

Change subject: rockchip/rk3399: Add MIPI driver
......................................................................


Patch Set 7:

Thank you. So from this it seems pretty clear that this is a panel-specific delay between SLPOUT (I assume this is EXIT_SLEEP_MODE?) and DISON (SET_DISPLAY_ON?). In that case, everything in my last two comments applies: you should probably move the delay to where you have the msleep(12) right now. It's probably fine to reduce it to 120ms again if the datasheet explicitly says that. I see no justification for an msleep(12) anywhere else, so unless you know a good reason for it you can probably leave it out. Also, since this is a panel-specific value it needs to come from devicetree.cb and get passed in to the function as I described.

-- 
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul at chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nickey.yang at rock-chips.com
Gerrit-HasComments: No