[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19693 )

Change subject: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19693/1/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

PS1, Line 270: if
Would it make sense to use else if () here so that if for any reason CONFIG_SOC_UART_DEBUG and CONFIG_DRIVERS_UART_8250IO are both selected the FSP parameters wouldn't be overwritten?
Or is that a more theoretical scenario?


-- 
To view, visit https://review.coreboot.org/19693
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7d0b54edd18acf793849aef352afbcaeb68b9
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes