[coreboot-gerrit] Change in coreboot[master]: [WIP]ec/lenovo/h8: Add panic method

Patrick Rudolph (Code Review) gerrit at coreboot.org
Mon May 15 18:17:19 CEST 2017


Patrick Rudolph has uploaded a new change for review. ( https://review.coreboot.org/19695 )

Change subject: [WIP]ec/lenovo/h8: Add panic method
......................................................................

[WIP]ec/lenovo/h8: Add panic method

Flash all LEDs to singal panic.
To be used with weak ec_panic method.

Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/ec/lenovo/h8/h8.c
M src/ec/lenovo/h8/h8.h
2 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/19695/1

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index b259d9a..272caf1 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -158,6 +158,13 @@
 	return ec_read(H8_STATUS1) & 0x5 ? 0 : 1;
 }
 
+void h8_panic(void)
+{
+	/* Flash all LEDs */
+	for (size_t i = 0; i < 0x10; i++)
+		ec_write(H8_LED_CONTROL, H8_LED_CONTROL_BLINK | i);
+}
+
 u8 h8_build_id_and_function_spec_version(char *buf, u8 buf_len)
 {
 	u8 i, c;
diff --git a/src/ec/lenovo/h8/h8.h b/src/ec/lenovo/h8/h8.h
index 42d279f..d014ecc 100644
--- a/src/ec/lenovo/h8/h8.h
+++ b/src/ec/lenovo/h8/h8.h
@@ -27,6 +27,7 @@
 int h8_ultrabay_device_present(void);
 u8 h8_build_id_and_function_spec_version(char *buf, u8 buf_len);
 void h8_usb_always_on(void);
+void h8_panic(void);
 
 void h8_mainboard_init_dock (void);
 

-- 
To view, visit https://review.coreboot.org/19695
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>



More information about the coreboot-gerrit mailing list