[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support

Patrick Rudolph (Code Review) gerrit at coreboot.org
Sat May 13 10:45:34 CEST 2017


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/18011 )

Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/18011/9/src/mainboard/lenovo/t430/smihandler.c
File src/mainboard/lenovo/t430/smihandler.c:

Line 29: static void mainboard_smm_init(void)
> I've been looking at this lately, because I wanted to trace down
It's set in h8_enable if devicetree has correct config0 entry. If devicetree is broken, like the one generated by autoport it wont work at all.


-- 
To view, visit https://review.coreboot.org/18011
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list