[coreboot-gerrit] Change in coreboot[master]: util/cbmem: mmap underflow on low addresses

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19679 )

Change subject: util/cbmem: mmap underflow on low addresses
......................................................................


Patch Set 2: Code-Review+2

> Could you please give more specific instructions on how to reproduce the issue?

You need any x86 platform where the first mmap() for offset 0x0 fails.  This happens on Braswell-based Chromebooks due to broken memory tables, for example. You can also replace (v == MAP_FAILED) with (1) if you just want to see the kernel crash.

-- 
To view, visit https://review.coreboot.org/19679
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32b0c15b2f1aa43fc57656d5d2d5f0e4e90e94ef
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No