[coreboot-gerrit] Change in coreboot[master]: arch/arm64: Use variables of the right size for msr/mrs opcodes

Philippe Mathieu-Daudé (Code Review) gerrit at coreboot.org
Fri May 12 18:05:17 CEST 2017


Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19661 )

Change subject: arch/arm64: Use variables of the right size for msr/mrs opcodes
......................................................................


Patch Set 1: -Code-Review

> As for using uint64_t, that would be wrong: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0488d/ch09s03s01.html specifies cntfrq_el0 to be 32 bit wide.

Ok!

-- 
To view, visit https://review.coreboot.org/19661
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c8b9fe3a1adc521e393c2e2a0216f7f425a2a3e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list