[coreboot-gerrit] Change in coreboot[master]: vexpress: add gfx init

[Philippe Mathieu-Daudé (Code Review)]

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/13749 )

Change subject: vexpress: add gfx init
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

I put a -1 to wait your reply about memory barrier.

https://review.coreboot.org/#/c/13749/7/src/mainboard/emulation/qemu-armv7/mainboard.c
File src/mainboard/emulation/qemu-armv7/mainboard.c:

PS7, Line 32: uint32_t *
shouldn't this be volatile?


PS7, Line 33: pl111[0] = (width / 4) - 4;
why not better use the safer write32() from <arch/io.h> which use memory barriers?
(same following lines)


-- 
To view, visit https://review.coreboot.org/13749
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eff29b74d7df331dcbf2c25799eaae4911e54fc
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vladimir Serbinenko <phcoder at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Vladimir Serbinenko <phcoder at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes