[coreboot-gerrit] Change in coreboot[master]: arch/arm64: Use variables of the right size for msr/mrs opcodes

[Philippe Mathieu-Daudé (Code Review)]

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19661 )

Change subject: arch/arm64: Use variables of the right size for msr/mrs opcodes
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/clock.c
File src/arch/arm64/armv8/lib/clock.c:

PS1, Line 24: uint32_t
Clang appears to be right, why not use use(uint64_t freq)? it seems cleaner to me.


https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/pstate.c
File src/arch/arm64/armv8/lib/pstate.c:

PS1, Line 51: uint32_t
same here, uint64_t arg


PS1, Line 199: uint32_t
and here uint64_t fpcr


PS1, Line 229: uint32_t
also here uint64_t nzcv


PS1, Line 287: uint32_t
here, and many following ;)


-- 
To view, visit https://review.coreboot.org/19661
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c8b9fe3a1adc521e393c2e2a0216f7f425a2a3e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes