[coreboot-gerrit] Change in coreboot[master]: src/sb/bd82x6x: Use default DxxIP and DxxIR

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19662 )

Change subject: src/sb/bd82x6x: Use default DxxIP and DxxIR
......................................................................


Patch Set 10:

(3 comments)

https://review.coreboot.org/#/c/19662/10/src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl
File src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl:

PS10, Line 23: /*  GFX         PCIe   INTA -> PIRQA (MSI) */
> I don't think these comments are still useful, do you?
nope not useful. On the ich7 equivalent I added a comment to which function the INT is connected. might be good to do so here too.


PS10, Line 26: ivy only
> Actually, Panther Point only, no matter the CPU.
makes sense


Line 44: 			Package() { 0x001fffff, 1, 0, 17 }, /* D31IP_SMIP  SMBUS  INTB -> PIRQB */
> Did you check actual register values, my datasheet (7-series) is
No sandy board here anymore (I tried to port a Dell for the fun of it but it died before I could complete the port).

Actually not a bad idea and likely very generic.


-- 
To view, visit https://review.coreboot.org/19662
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7660c03dca0b7db34cf725488b6d6538fdfde62d
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes