[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801gx: Consolidate interrupt routing

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu May 11 17:20:34 CEST 2017


Hello Vladimir Serbinenko, Paul Menzel, build bot (Jenkins), coreboot org,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19017

to look at the new patch set (#11).

Change subject: sb/intel/i82801gx: Consolidate interrupt routing
......................................................................

sb/intel/i82801gx: Consolidate interrupt routing

The current code tries to make routing per-board, presumably for optimizing
IRQ balancing but instead fails at providing an error-free default.
Rewrite in unified and simplified way at the cost of minor performance hit
on very old OS.

This uses the default DxxIP and DxxIR to set up PCI IRQ routing and
sets ACPI accordingly.

Change-Id: I46838d2249c6fefedf9e2c63ade0812d22e7d627
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/apple/macbook21/Kconfig
D src/mainboard/apple/macbook21/acpi/i945_pci_irqs.asl
M src/mainboard/apple/macbook21/devicetree.cb
M src/mainboard/apple/macbook21/romstage.c
M src/mainboard/asus/p5gc-mx/Kconfig
M src/mainboard/asus/p5gc-mx/devicetree.cb
M src/mainboard/getac/p470/Kconfig
D src/mainboard/getac/p470/acpi/i945_pci_irqs.asl
M src/mainboard/getac/p470/devicetree.cb
M src/mainboard/getac/p470/romstage.c
D src/mainboard/gigabyte/ga-945gcm-s2l/acpi/i945_pci_irqs.asl
M src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb
M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c
M src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
D src/mainboard/gigabyte/ga-g41m-es2l/acpi/x4x_pci_irqs.asl
M src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
M src/mainboard/gigabyte/ga-g41m-es2l/romstage.c
M src/mainboard/ibase/mb899/Kconfig
D src/mainboard/ibase/mb899/acpi/i945_pci_irqs.asl
M src/mainboard/ibase/mb899/devicetree.cb
M src/mainboard/ibase/mb899/romstage.c
M src/mainboard/intel/d510mo/Kconfig
D src/mainboard/intel/d510mo/acpi/pineview_pci_irqs.asl
M src/mainboard/intel/d510mo/devicetree.cb
M src/mainboard/intel/d510mo/romstage.c
M src/mainboard/intel/d945gclf/Kconfig
D src/mainboard/intel/d945gclf/acpi/i945_pci_irqs.asl
M src/mainboard/intel/d945gclf/devicetree.cb
M src/mainboard/intel/d945gclf/romstage.c
M src/mainboard/kontron/986lcd-m/Kconfig
D src/mainboard/kontron/986lcd-m/acpi/i945_pci_irqs.asl
M src/mainboard/kontron/986lcd-m/devicetree.cb
M src/mainboard/kontron/986lcd-m/romstage.c
M src/mainboard/lenovo/t60/Kconfig
D src/mainboard/lenovo/t60/acpi/i945_pci_irqs.asl
M src/mainboard/lenovo/t60/devicetree.cb
M src/mainboard/lenovo/t60/romstage.c
M src/mainboard/lenovo/x60/Kconfig
D src/mainboard/lenovo/x60/acpi/i945_pci_irqs.asl
M src/mainboard/lenovo/x60/devicetree.cb
M src/mainboard/lenovo/x60/romstage.c
M src/mainboard/roda/rk886ex/Kconfig
D src/mainboard/roda/rk886ex/acpi/i945_pci_irqs.asl
M src/mainboard/roda/rk886ex/devicetree.cb
M src/mainboard/roda/rk886ex/romstage.c
M src/northbridge/intel/i945/acpi/hostbridge.asl
M src/northbridge/intel/i945/early_init.c
M src/northbridge/intel/pineview/acpi/hostbridge.asl
M src/northbridge/intel/pineview/early_init.c
M src/northbridge/intel/x4x/acpi/hostbridge.asl
M src/southbridge/intel/i82801gx/acpi/ich7.asl
R src/southbridge/intel/i82801gx/acpi/irq.asl
M src/southbridge/intel/i82801gx/chip.h
M src/southbridge/intel/i82801gx/i82801gx.h
M src/southbridge/intel/i82801gx/lpc.c
55 files changed, 384 insertions(+), 1,249 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/19017/11
-- 
To view, visit https://review.coreboot.org/19017
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46838d2249c6fefedf9e2c63ade0812d22e7d627
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vladimir Serbinenko <phcoder at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>



More information about the coreboot-gerrit mailing list