[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Fix raminit with mixed raw card types

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19652 )

Change subject: nb/intel/gm45: Fix raminit with mixed raw card types
......................................................................


nb/intel/gm45: Fix raminit with mixed raw card types

`cardF[n]` should indicate whether the DIMM in channel n is of
raw card type F. However, `cardF[1]` was initialised with the
value meant for `cardF[0]`. This patch results in the correct
initialisation of `cardF`.

Tested on a Lenovo T400 containing two DIMMs: one of raw card
type F and the other of raw card type B. Before the patch, the
system would not boot. After the patch, the system boots with all
of the memory functional.

Change-Id: I7409df0b8c67d7efbdadae39dc718c8df7a92552
Signed-off-by: Tristan Corrick <tristancorrick86 at gmail.com>
Reviewed-on: https://review.coreboot.org/19652
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Nico Huber <nico.h at gmx.de>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
M src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Arthur Heymans: Looks good to me, but someone else must approve
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved



diff --git a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
index c5614e1..7d57a4e 100644
--- a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
+++ b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
@@ -211,7 +211,7 @@
 
 	const int cardF[] = {
 		dimms[0].card_type == 0xf,
-		dimms[0].card_type == 0xf,
+		dimms[1].card_type == 0xf,
 	};
 
 	const unsigned int t_bound =

-- 
To view, visit https://review.coreboot.org/19652
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7409df0b8c67d7efbdadae39dc718c8df7a92552
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Tristan Corrick <tristancorrick86 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>