[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu May 11 16:44:49 CEST 2017


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19654 )

Change subject: mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option
......................................................................


mb/lenovo/x60/t60: Remove `fn_ctrl_swap` option

The EC doesn't support it.

Change-Id: Id2964002406a5fcf992f0ffc3627e3f66a2bb13f
Signed-off-by: Nico Huber <nico.huber at secunet.com>
Reviewed-on: https://review.coreboot.org/19654
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
M src/mainboard/lenovo/t60/cmos.default
M src/mainboard/lenovo/t60/cmos.layout
M src/mainboard/lenovo/x60/cmos.default
M src/mainboard/lenovo/x60/cmos.layout
4 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Arthur Heymans: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/mainboard/lenovo/t60/cmos.default b/src/mainboard/lenovo/t60/cmos.default
index 03b92e3..b22ff41 100644
--- a/src/mainboard/lenovo/t60/cmos.default
+++ b/src/mainboard/lenovo/t60/cmos.default
@@ -14,8 +14,7 @@
 wlan=Enable
 wwan=Enable
 trackpoint=Enable
-fn_ctrl_swap=Disable
 sticky_fn=Disable
 power_management_beeps=Enable
 low_battery_beep=Enable
-gfx_uma_size=8M
\ No newline at end of file
+gfx_uma_size=8M
diff --git a/src/mainboard/lenovo/t60/cmos.layout b/src/mainboard/lenovo/t60/cmos.layout
index af788c6..b11852a 100644
--- a/src/mainboard/lenovo/t60/cmos.layout
+++ b/src/mainboard/lenovo/t60/cmos.layout
@@ -80,7 +80,7 @@
 952         8       h       0        volume
 960         1       e       9        first_battery
 961         1       e       1        trackpoint
-962         1       e       1        fn_ctrl_swap
+#962         1       r       0        unused
 963         1       e       1        sticky_fn
 964         1       e       1        power_management_beeps
 965         1       e       1        low_battery_beep
diff --git a/src/mainboard/lenovo/x60/cmos.default b/src/mainboard/lenovo/x60/cmos.default
index 4e72734..9ed16d0 100644
--- a/src/mainboard/lenovo/x60/cmos.default
+++ b/src/mainboard/lenovo/x60/cmos.default
@@ -14,8 +14,7 @@
 wlan=Enable
 wwan=Enable
 trackpoint=Enable
-fn_ctrl_swap=Disable
 sticky_fn=Disable
 power_management_beeps=Enable
 low_battery_beep=Enable
-gfx_uma_size=8M
\ No newline at end of file
+gfx_uma_size=8M
diff --git a/src/mainboard/lenovo/x60/cmos.layout b/src/mainboard/lenovo/x60/cmos.layout
index ebc6678..7671439 100644
--- a/src/mainboard/lenovo/x60/cmos.layout
+++ b/src/mainboard/lenovo/x60/cmos.layout
@@ -78,7 +78,7 @@
 951         1       e       1        wwan
 952         1       e       1        wlan
 953         1       e       1        trackpoint
-954         1       e       1        fn_ctrl_swap
+#954         1       r       0        unused
 955         1       e       1        sticky_fn
 956         1       e       1        power_management_beeps
 959         1       e       1        low_battery_beep

-- 
To view, visit https://review.coreboot.org/19654
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2964002406a5fcf992f0ffc3627e3f66a2bb13f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list