[coreboot-gerrit] Change in coreboot[master]: src/sb/bd82x6x: Use default DxxIP and DxxIR

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19662 )

Change subject: src/sb/bd82x6x: Use default DxxIP and DxxIR
......................................................................


Patch Set 9: Code-Review-1

(3 comments)

devicetree with mptable generation still needs to be fixed for this...

https://review.coreboot.org/#/c/19662/4/src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl
File src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl:

> I suppose this can be included from pch.asl now? instead of each dsdt.asl.
ok


PS4, Line 24: 			/* Onboard graphics (IGD)	0:2.0 */
            : 			Package() { 0x0002ffff, 0, 0, 16 },/*  GFX                INTA -> PIRQA (MSI) */
            : 			/* XHCI	0:14.0 (ivy only) */
> wrong pins
I'll remove it.


PS4, Line 59: A
> A?
thanks, must have forgotten it.


-- 
To view, visit https://review.coreboot.org/19662
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7660c03dca0b7db34cf725488b6d6538fdfde62d
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes