[coreboot-gerrit] Change in coreboot[master]: intelmetool: Enhance missing packages help

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu May 11 09:44:46 CEST 2017


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19617 )

Change subject: intelmetool: Enhance missing packages help
......................................................................


intelmetool: Enhance missing packages help

On Ubuntu 16.04 the libpci-dev package is required.

Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c
Signed-off-by: Vincent Legoll <vincent.legoll at gmail.com>
Reviewed-on: https://review.coreboot.org/19617
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
---
M util/intelmetool/Makefile
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Philipp Deppenwiese: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile
index 4461f86..affcf30 100644
--- a/util/intelmetool/Makefile
+++ b/util/intelmetool/Makefile
@@ -70,11 +70,12 @@
 export LIBPCI_TEST
 
 pciutils:
-	@printf "\nChecking for pciutils and zlib... "
+	@printf "\nChecking for development libraries: pci and zlib... "
 	@echo "$$LIBPCI_TEST" > .test.c
 	@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 &&	  \
 		printf "found.\n" || ( printf "not found.\n\n"; 	  \
-		printf "Please install pciutils-devel and zlib-devel.\n"; \
+		printf "For RPM based distributions like Fedora, please install pciutils-devel and zlib-devel.\n"; \
+		printf "For DEB based distributions, please install libpci-dev and zlib1g-dev.\n"; \
 		rm -f .test.c .test; exit 1)
 	@rm -rf .test.c .test .test.dSYM
 

-- 
To view, visit https://review.coreboot.org/19617
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vincent Legoll <vincent.legoll at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Vincent Legoll <vincent.legoll at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list