[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Add MIPI driver

[Anonymous Coward (Code Review)]

nickey.yang at rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19477 )

Change subject: rockchip/rk3399: Add MIPI driver
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/19477/5/src/soc/rockchip/rk3399/mipi.c
File src/soc/rockchip/rk3399/mipi.c:

Line 432: 		return;
> You reduced the delay but you still didn't explain what it's for. Can you p
The SOC tells the panel to enter the display mode, and then wait for the panel to complete the initialization.the last SOC switch to the video mode to display. I tried the value of 100ms - 500ms, and then use the button to reset devices a number of times, when 100ms, the panel will showe blurred screen occasionally.so i set 120ms,and everythings works well.


-- 
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul at chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nickey.yang at rock-chips.com
Gerrit-HasComments: Yes