[coreboot-gerrit] Change in coreboot[master]: drivers/storage: Fix array references

[Lee Leahy (Code Review)]

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19643 )

Change subject: drivers/storage: Fix array references
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19643/2/src/drivers/storage/storage.c
File src/drivers/storage/storage.c:

PS2, Line 77: ARRAY_SIZE(decimal_list) - 1
> Why is it minus 1? If the '1' entries don't matter remove them? And just ch
The less than ensures that index only references actual elements of the array.  The minus one handles the case where capacity is zero and returns an index of (ARRAY_SIZE(array) - 1) which is the last element of the array with a divisor of 1 and units of bytes.  This eliminates the need for special case code to handle the zero capacity case.  Coverity should be happy now since all possible exits from the loop have a valid index value.


-- 
To view, visit https://review.coreboot.org/19643
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c96e78417b667438a00ee22c70894a00d13291
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes