[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Add usage of external RTC RX6110 SA

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19647 )

Change subject: siemens/mc_apl1: Add usage of external RTC RX6110 SA
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19647/1/src/mainboard/siemens/mc_apl1/devicetree.cb
File src/mainboard/siemens/mc_apl1/devicetree.cb:

PS1, Line 44: register "user_weekday" = "1"
The 1st of July 2004 was a Thursday. So you probably should set user_weekday to "4", or?


-- 
To view, visit https://review.coreboot.org/19647
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5aceb4401f0bb059ef893dfe7d157716c82e4a76
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes