[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Implement Global Reset MEI message

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/16902 )

Change subject: soc/intel/skylake: Implement Global Reset MEI message
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/16902/9/src/soc/intel/skylake/me.c
File src/soc/intel/skylake/me.c:

Line 588: 			status = recv_heci_packet(&head, message + (cur >> 2),
> Ya. It looks to still be using bytes and dwords in the wrong place.
we shall get rid of this code very soon as and when we migrate into common CSE code for big core platform as well. This is next target. if you need this to be fixed now,  need to look


-- 
To view, visit https://review.coreboot.org/16902
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If326a137eeadaa695668b76b84c510e12c546024
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes