[coreboot-gerrit] Change in coreboot[master]: drivers/storage: Remove set_control_reg

[Lee Leahy (Code Review)]

Lee Leahy has submitted this change and it was merged. ( https://review.coreboot.org/19629 )

Change subject: drivers/storage: Remove set_control_reg
......................................................................


drivers/storage: Remove set_control_reg

Remove unused field in generic SD/MMC controller data structure.

TEST=Build and run on Galileo Gen2

Change-Id: I7169dca07509a6f2513d62b593742daf764010b2
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
Reviewed-on: https://review.coreboot.org/19629
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
M src/drivers/storage/sdhci.c
M src/include/device/sd_mmc_ctrlr.h
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/drivers/storage/sdhci.c b/src/drivers/storage/sdhci.c
index f05a47e..c17aa27 100644
--- a/src/drivers/storage/sdhci.c
+++ b/src/drivers/storage/sdhci.c
@@ -550,9 +550,6 @@
 	u32 bus_width;
 	int version;
 
-	if (ctrlr->set_control_reg)
-		ctrlr->set_control_reg(ctrlr);
-
 	/* Set the clock frequency */
 	if (ctrlr->bus_hz != ctrlr->request_hz)
 		sdhci_set_clock(sdhci_ctrlr, ctrlr->request_hz);
diff --git a/src/include/device/sd_mmc_ctrlr.h b/src/include/device/sd_mmc_ctrlr.h
index c3b4f60..b7541da 100644
--- a/src/include/device/sd_mmc_ctrlr.h
+++ b/src/include/device/sd_mmc_ctrlr.h
@@ -127,7 +127,6 @@
 	int (*send_cmd)(struct sd_mmc_ctrlr *ctrlr,
 		struct mmc_command *cmd, struct mmc_data *data);
 	void (*set_ios)(struct sd_mmc_ctrlr *ctrlr);
-	void (*set_control_reg)(struct sd_mmc_ctrlr *ctrlr);
 	void (*tuning_start)(struct sd_mmc_ctrlr *ctrlr, int retune);
 	int (*is_tuning_complete)(struct sd_mmc_ctrlr *ctrlr, int *successful);
 

-- 
To view, visit https://review.coreboot.org/19629
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7169dca07509a6f2513d62b593742daf764010b2
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>