[coreboot-gerrit] Change in coreboot[master]: mainboard: Add ASRock G41C-GS
Arthur Heymans (Code Review)
gerrit at coreboot.org
Tue May 9 14:13:17 CEST 2017
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18993 )
Change subject: mainboard: Add ASRock G41C-GS
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/18993/10/src/mainboard/asrock/g41c-gs/romstage.c
File src/mainboard/asrock/g41c-gs/romstage.c:
Line 69: }
> Did you confirm that the reserved bits have the same value as you
According to datasheets those reserved bits are 0 by default. It still seemed to work fine.
--
To view, visit https://review.coreboot.org/18993
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I992ee07b742dfc59733ce0f3a9be202a530ec6cc
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list