[coreboot-gerrit] Change in coreboot[master]: src/include: remove the __ROMCC__ to enable snprintf

Caesar Wang (Code Review) gerrit at coreboot.org
Tue May 9 12:00:22 CEST 2017


Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19622 )

Change subject: src/include: remove the __ROMCC__ to enable snprintf
......................................................................


Patch Set 4:

> edit: Oh, and only now I saw your comment. But the code you
 > referred to is no longer relevant? This used to say __PRE_RAM__ but
 > it was changed to __ROMCC__ in https://review.coreboot.org/17289,
 > which I presume was correct (since Aaron put it there and he would
 > probably know best).

Yes, https://review.coreboot.org/17289 works for me now.

-- 
To view, visit https://review.coreboot.org/19622
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6966dc8ebc911b954bc5ea8981df093df226dd6c
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list