[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Add MIPI driver

[Anonymous Coward (Code Review)]

nickey.yang at rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19477 )

Change subject: rockchip/rk3399: Add MIPI driver
......................................................................


Patch Set 5:

(7 comments)

https://review.coreboot.org/#/c/19477/2/src/soc/rockchip/rk3399/mipi.c
File src/soc/rockchip/rk3399/mipi.c:

Line 406: {
> That doesn't require you to have this here, though. You can just put a
No verified on the 3288 platform with Mipi panel, so can we put it here first?


https://review.coreboot.org/#/c/19477/4/src/soc/rockchip/rk3399/mipi.c
File src/soc/rockchip/rk3399/mipi.c:

PS4, Line 182: 
> target_bps should also be unsigned long, just in case. Also, I think it wou
Done


PS4, Line 183: target_bps
> 1500 * MHz
Done


PS4, Line 206:  / n) <
> 5 * MHz and 40 * MHz
Done


PS4, Line 216: ak;
> This should also be lane_bps instead and all subsequent calculations with i
Done


Line 405: void rk_mipi_prepare(const struct edid *edid)
> Remove this and just do
Done


Line 436
> I feel like I must have asked this somewhere already... where do the 500ms 
Done


-- 
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul at chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nickey.yang at rock-chips.com
Gerrit-HasComments: Yes