[coreboot-gerrit] Change in coreboot[master]: mainboard/pcengines/apu2: Add LPC TPM support

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18523 )

Change subject: mainboard/pcengines/apu2: Add LPC TPM support
......................................................................


Patch Set 12:

(1 comment)

https://review.coreboot.org/#/c/18523/12/src/mainboard/pcengines/apu2/romstage.c
File src/mainboard/pcengines/apu2/romstage.c:

PS12, Line 96: 
             : #if CONFIG_LPC_TPM
Avoid the preprocessor #if if possible.  You should use:
 if (IS_ENABLED(CONFIG_LPC_TPM))

But since you're selecting LPC_TPM, and it will always be on, you could even just skip the if if you wanted.


-- 
To view, visit https://review.coreboot.org/18523
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes