[coreboot-gerrit] Change in coreboot[master]: drivers/storage: Remove set_control_reg

Lee Leahy (Code Review) gerrit at coreboot.org
Mon May 8 23:48:30 CEST 2017


Lee Leahy has uploaded a new change for review. ( https://review.coreboot.org/19629 )

Change subject: drivers/storage: Remove set_control_reg
......................................................................

drivers/storage: Remove set_control_reg

Remove unused field in generic SD/MMC controller data structure.

TEST=Build and run on Galileo Gen2

Change-Id: I7169dca07509a6f2513d62b593742daf764010b2
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
M src/drivers/storage/sdhci.c
M src/include/device/sd_mmc_ctrlr.h
2 files changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/19629/1

diff --git a/src/drivers/storage/sdhci.c b/src/drivers/storage/sdhci.c
index f05a47e..c17aa27 100644
--- a/src/drivers/storage/sdhci.c
+++ b/src/drivers/storage/sdhci.c
@@ -550,9 +550,6 @@
 	u32 bus_width;
 	int version;
 
-	if (ctrlr->set_control_reg)
-		ctrlr->set_control_reg(ctrlr);
-
 	/* Set the clock frequency */
 	if (ctrlr->bus_hz != ctrlr->request_hz)
 		sdhci_set_clock(sdhci_ctrlr, ctrlr->request_hz);
diff --git a/src/include/device/sd_mmc_ctrlr.h b/src/include/device/sd_mmc_ctrlr.h
index c3b4f60..b7541da 100644
--- a/src/include/device/sd_mmc_ctrlr.h
+++ b/src/include/device/sd_mmc_ctrlr.h
@@ -127,7 +127,6 @@
 	int (*send_cmd)(struct sd_mmc_ctrlr *ctrlr,
 		struct mmc_command *cmd, struct mmc_data *data);
 	void (*set_ios)(struct sd_mmc_ctrlr *ctrlr);
-	void (*set_control_reg)(struct sd_mmc_ctrlr *ctrlr);
 	void (*tuning_start)(struct sd_mmc_ctrlr *ctrlr, int retune);
 	int (*is_tuning_complete)(struct sd_mmc_ctrlr *ctrlr, int *successful);
 

-- 
To view, visit https://review.coreboot.org/19629
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7169dca07509a6f2513d62b593742daf764010b2
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>



More information about the coreboot-gerrit mailing list