[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19090 )

Change subject: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19090/2/src/northbridge/intel/gm45/gma.c
File src/northbridge/intel/gm45/gma.c:

Line 668: 			printk(BIOS_ERR, "gma: Error reading blc pwm from CBFS\n");
> line too long
I'll adapt the codeflow so that there is less indentation.


Line 678: #define MINIMUM_BLC_PWM 50
> seems very low
It is... maybe 100?


PS2, Line 745: (blc_pwm_cbfs >= MINIMUM_BLC_PWM) && (blc_pwm_cbfs < 0xffff)
> Better check this before casting to `int`.
Since it is actually cast into an int just checking that the value is above the (positive) minimal should do it right, or is that shady (mis)use of casts?


-- 
To view, visit https://review.coreboot.org/19090
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82e90e47ffc42b8d7062af87f6b174cd03445bb7
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kevin Keijzer <kevin at librepractice.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes