[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/galileo: Add SD controller configuration

Lee Leahy (Code Review) gerrit at coreboot.org
Mon May 8 19:14:14 CEST 2017


Lee Leahy has submitted this change and it was merged. ( https://review.coreboot.org/19212 )

Change subject: mainboard/intel/galileo: Add SD controller configuration
......................................................................


mainboard/intel/galileo: Add SD controller configuration

Configure the SD controller to handle the SD card slot.
* Galileo supports a removable SD card slot.
* Set SD card initialization frequency to 100 MHz.
* Set default removable delays.
* Build SD/MMC components by default

TEST=Build and run on Galileo Gen2

Change-Id: Iaf4faa40fe01eca98abffa2681f61fd8e059f0c4
Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
Reviewed-on: https://review.coreboot.org/19212
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/intel/galileo/Kconfig
M src/mainboard/intel/galileo/Makefile.inc
A src/mainboard/intel/galileo/sd.c
3 files changed, 44 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/intel/galileo/Kconfig b/src/mainboard/intel/galileo/Kconfig
index 0ab682c..4ae412f 100644
--- a/src/mainboard/intel/galileo/Kconfig
+++ b/src/mainboard/intel/galileo/Kconfig
@@ -179,4 +179,12 @@
 	  When an FMD descriptionn file is specified, the build system uses it
 	  instead of creating a default FMAP file.
 
+config ENABLE_SD_TESTING
+	bool "Enable SD card testing"
+	default y
+	select DRIVERS_STORAGE_SD
+	select SDHC_DEBUG
+	select STORAGE_LOG
+	select STORAGE_TEST
+
 endif # BOARD_INTEL_QUARK
diff --git a/src/mainboard/intel/galileo/Makefile.inc b/src/mainboard/intel/galileo/Makefile.inc
index f2fda31..25f672e 100644
--- a/src/mainboard/intel/galileo/Makefile.inc
+++ b/src/mainboard/intel/galileo/Makefile.inc
@@ -26,6 +26,7 @@
 
 romstage-y += gpio.c
 romstage-y += reg_access.c
+romstage-$(CONFIG_DRIVERS_STORAGE_SD) += sd.c
 romstage-$(CONFIG_VBOOT) += vboot.c
 
 postcar-y += gpio.c
@@ -33,3 +34,4 @@
 
 ramstage-y += gpio.c
 ramstage-y += reg_access.c
+ramstage-$(CONFIG_DRIVERS_STORAGE_SD) += sd.c
diff --git a/src/mainboard/intel/galileo/sd.c b/src/mainboard/intel/galileo/sd.c
new file mode 100644
index 0000000..d13b318
--- /dev/null
+++ b/src/mainboard/intel/galileo/sd.c
@@ -0,0 +1,34 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2017 Intel Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <device/sdhci.h>
+#include <device/storage.h>
+
+void soc_sd_mmc_controller_quirks(struct sd_mmc_ctrlr *ctrlr)
+{
+	/* Specify the additional driver support */
+	ctrlr->caps |= DRVR_CAP_REMOVABLE;
+
+	/* ADMA currently not working on Quark */
+	ctrlr->caps &= ~DRVR_CAP_AUTO_CMD12;
+
+	/* Set initialization clock frequency */
+	ctrlr->f_min = 100 * CLOCK_KHZ;
+
+	/* Set the initialization delays */
+	ctrlr->mdelay_before_cmd0 = 1;
+	ctrlr->mdelay_after_cmd0 = 2;
+}

-- 
To view, visit https://review.coreboot.org/19212
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf4faa40fe01eca98abffa2681f61fd8e059f0c4
Gerrit-PatchSet: 13
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list