[coreboot-gerrit] Change in coreboot[master]: mainboard: Add ASRock G41C-GS

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18993 )

Change subject: mainboard: Add ASRock G41C-GS
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

https://review.coreboot.org/#/c/18993/6/src/mainboard/asrock/g41c-gs/Kconfig
File src/mainboard/asrock/g41c-gs/Kconfig:

Line 36: 	select HAVE_ACPI_RESUME
> I'm confused here, does this mean you won't get the owner to test
Sadly not and I'm really unhappy about it too... I'll try to find one of these boards but until then I feel like this is wasting my and especially your time.


https://review.coreboot.org/#/c/18993/6/src/mainboard/asrock/g41c-gs/dsdt.asl
File src/mainboard/asrock/g41c-gs/dsdt.asl:

Line 37: 			#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
> ok
its a bug. /drivers/intel/gma/acpi/configure_brightness_levels.asl needs it...


-- 
To view, visit https://review.coreboot.org/18993
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I992ee07b742dfc59733ce0f3a9be202a530ec6cc
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes