[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Add eMMC as thermal sensor

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19524 )

Change subject: mb/google/poppy: Add eMMC as thermal sensor
......................................................................


mb/google/poppy: Add eMMC as thermal sensor

This patch adds the eMMC as one of the thermal sensor under DPTF.
Also, updates few comments for better interpretation and mapping.

BUG=None
BRANCH=None
TEST=Built for poppy.

Change-Id: I6d05bb7a2f857dc5bc98227c8327b2ff1bd5b913
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar at intel.com>
Reviewed-on: https://review.coreboot.org/19524
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/dptf.asl
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Paul Menzel: Looks good to me, but someone else must approve
  Duncan Laurie: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/dptf.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/dptf.asl
index 7f6cd8e..cbe4b7a 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/dptf.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/dptf.asl
@@ -32,6 +32,11 @@
 #define DPTF_TSR2_PASSIVE	52
 #define DPTF_TSR2_CRITICAL	75
 
+#define DPTF_TSR3_SENSOR_ID	4
+#define DPTF_TSR3_SENSOR_NAME	"eMMC"
+#define DPTF_TSR3_PASSIVE	55
+#define DPTF_TSR3_CRITICAL	75
+
 #define DPTF_ENABLE_CHARGER
 
 /* Charger performance states, board-specific values from charger and EC */
@@ -46,16 +51,19 @@
 	/* CPU Throttle Effect on CPU */
 	Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 },
 
-	/* CPU Effect on Temp Sensor 0 */
+	/* CPU Throttle Effect on Ambient (TSR0) */
 	Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR0, 100, 600, 0, 0, 0, 0 },
 
 #ifdef DPTF_ENABLE_CHARGER
-	/* Charger Effect on Temp Sensor 1 */
-	Package () { \_SB.DPTF.TCHG, \_SB.DPTF.TSR1, 200, 600, 0, 0, 0, 0 },
+	/* Charger Throttle Effect on Charger (TSR1) */
+	Package () { \_SB.DPTF.TCHG, \_SB.DPTF.TSR1, 100, 600, 0, 0, 0, 0 },
 #endif
 
-	/* CPU Effect on Temp Sensor 2 */
+	/* CPU Throttle Effect on DRAM (TSR2) */
 	Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR2, 100, 90, 0, 0, 0, 0 },
+
+	/* CPU Throttle Effect on eMMC (TSR3) */
+	Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR3, 100, 600, 0, 0, 0, 0 },
 })
 
 Name (MPPC, Package ()

-- 
To view, visit https://review.coreboot.org/19524
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d05bb7a2f857dc5bc98227c8327b2ff1bd5b913
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>