[coreboot-gerrit] Change in coreboot[master]: intelmetool: free sb pci_dev struct allocated by pci_get_dev()
Martin Roth (Code Review)
gerrit at coreboot.org
Fri May 5 22:38:25 CEST 2017
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19561 )
Change subject: intelmetool: free sb pci_dev struct allocated by pci_get_dev()
......................................................................
intelmetool: free sb pci_dev struct allocated by pci_get_dev()
This fixes a memory leak in the activate_me() function.
Change-Id: I011b2f96122d8f88aed121352afe3f0d41edef60
Signed-off-by: Paul Wise <pabs3 at bonedaddy.net>
Reviewed-on: https://review.coreboot.org/19561
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
M util/intelmetool/intelmetool.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Paul Menzel: Looks good to me, but someone else must approve
Philipp Deppenwiese: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c
index d6fd0fe..62dc4d9 100644
--- a/util/intelmetool/intelmetool.c
+++ b/util/intelmetool/intelmetool.c
@@ -220,6 +220,7 @@
printf("MEI not hidden on PCI, checking if visible\n");
}
+ pci_free_dev(sb);
pci_cleanup(pacc);
return 0;
--
To view, visit https://review.coreboot.org/19561
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I011b2f96122d8f88aed121352afe3f0d41edef60
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Wise (Debian) <pabs at debian.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
More information about the coreboot-gerrit
mailing list