[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use intel/common/block/smbus code

Aamir Bohra (Code Review) gerrit at coreboot.org
Fri May 5 16:02:08 CEST 2017


Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19373 )

Change subject: soc/intel/skylake: Use intel/common/block/smbus code
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/19373/11/src/soc/intel/skylake/include/soc/pm.h
File src/soc/intel/skylake/include/soc/pm.h:

Line 54
> I don't think we should just delete this. I was jut noting we should change
Ok.Renamed it to TCO_SMI_EN in PS#12.


-- 
To view, visit https://review.coreboot.org/19373
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list