[coreboot-gerrit] Change in coreboot[master]: sb/intel/*: Use common SMBus functions

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19258 )

Change subject: sb/intel/*: Use common SMBus functions
......................................................................


Patch Set 14:

(3 comments)

https://review.coreboot.org/#/c/19258/10//COMMIT_MSG
Commit Message:

Line 11: implementations with a common file.
> Any reason why i82801dx is not touched?
forgot it.

its funny that it has smbus.c with supposedly ramstage functions but it is not even linked in...


Line 15: this function can reduce the time being spent to read SPD five-fold.
> Revisit kernel driver about these smbus/i2c block read functions. There was
command 6 does not seem to be used by the the i801 kernel driver...


https://review.coreboot.org/#/c/19258/14/src/southbridge/intel/common/smbus.c
File src/southbridge/intel/common/smbus.c:

PS14, Line 95: 	/* poll for it to start */
             : 	if (smbus_wait_until_active(smbus_base) < 0) {
             : 		return -4;
             : 	}
not sure if this is needed/desired...


-- 
To view, visit https://review.coreboot.org/19258
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962
Gerrit-PatchSet: 14
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes