[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common SMBus code

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 )

Change subject: soc/intel/common/block: Add Intel common SMBus code
......................................................................


Patch Set 10:

(2 comments)

https://review.coreboot.org/#/c/19372/9/src/soc/intel/common/block/smbus/smbuslib.c
File src/soc/intel/common/block/smbus/smbuslib.c:

PS9, Line 31: stopwatch_expired(&sw));
> parens around this call are not needed here and below.
Done


https://review.coreboot.org/#/c/19372/9/src/soc/intel/common/block/smbus/smbuslib.h
File src/soc/intel/common/block/smbus/smbuslib.h:

PS9, Line 22: 0
> This should really be PCI_BASE_ADDRESS_4 (from device/pci_def.h).
Ok.Removed.Using PCI_BASE_ADDRESS_4 in PS#10


-- 
To view, visit https://review.coreboot.org/19372
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamirbohra at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes