[coreboot-gerrit] Change in coreboot[master]: cr50: check if the new image needs to be enabled and act on it

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/18946 )

Change subject: cr50: check if the new image needs to be enabled and act on it
......................................................................


Patch Set 9:

> > I verified this to work with a 0.0.19 cr50 code on a reef. There
 > > were a few conflicts to resolve to cherry pick it into the reef
 > > branch, nothing major.
 > 
 > Thanks, Vadim. Can you paste an eventlog from your testing?

well, I messed up the conflict resolution in src/include/elog.h, so this event shows up as a thermal trip in the log, but otherwise here you go :) (this is after quite a bit of reboots)

> ssh 192.168.1.102 mosys eventlog list
Warning: Permanently added '192.168.1.102' (RSA) to the list of known hosts.
0 | 2017-05-04 20:15:46 | Log area cleared | 4088
1 | 2017-05-04 20:15:46 | Kernel Event | Clean Shutdown
2 | 2017-05-04 20:16:50 | System boot | 7
3 | 2017-05-04 20:16:50 | Last post code in previous boot | 0x34 | Unknown
4 | 2017-05-04 20:16:50 | Chrome OS Developer Mode
5 | 2017-05-04 20:16:50 | Memory Cache Update | Normal | Success
6 | 2017-05-04 20:16:50 | Memory Cache Update | Variable | Success
7 | 2017-05-04 20:19:07 | Kernel Event | Clean Shutdown
8 | 2017-05-04 20:19:13 | System boot | 8
9 | 2017-05-04 20:19:13 | System Reset
10 | 2017-05-04 20:19:14 | Chrome OS Developer Mode
11 | 2017-05-04 20:19:14 | CPU Thermal Trip
12 | 2017-05-04 20:19:14 | ACPI Enter | S5
13 | 2017-05-04 20:19:23 | System boot | 9
14 | 2017-05-04 20:19:23 | Chrome OS Developer Mode
15 | 2017-05-04 20:19:23 | Memory Cache Update | Variable | Success
16 | 2017-05-04 20:28:15 | Kernel Event | Clean Shutdown
17 | 2017-05-04 20:28:22 | System boot | 10
18 | 2017-05-04 20:28:22 | System Reset
19 | 2017-05-04 20:28:22 | ACPI Wake | S5
20 | 2017-05-04 20:28:22 | Chrome OS Developer Mode
21 | 2017-05-04 20:28:23 | CPU Thermal Trip
22 | 2017-05-04 20:28:23 | ACPI Enter | S5
23 | 2017-05-04 20:28:31 | System boot | 11
24 | 2017-05-04 20:28:31 | Chrome OS Developer Mode
25 | 2017-05-04 20:28:31 | Memory Cache Update | Variable | Success
26 | 2017-05-04 20:29:51 | Kernel Event | Clean Shutdown
27 | 2017-05-04 20:29:58 | System boot | 12
28 | 2017-05-04 20:29:58 | System Reset
29 | 2017-05-04 20:29:58 | ACPI Wake | S5
30 | 2017-05-04 20:29:58 | Chrome OS Developer Mode
31 | 2017-05-04 20:29:59 | CPU Thermal Trip
32 | 2017-05-04 20:29:59 | ACPI Enter | S5
33 | 2017-05-04 20:30:08 | System boot | 13
34 | 2017-05-04 20:30:08 | Chrome OS Developer Mode
35 | 2017-05-04 20:30:08 | Memory Cache Update | Variable | Success
36 | 2017-05-04 20:30:42 | System boot | 14
37 | 2017-05-04 20:30:42 | Chrome OS Developer Mode
38 | 2017-05-04 20:30:42 | Memory Cache Update | Variable | Success
39 | 2017-05-04 20:31:28 | Kernel Event | Clean Shutdown
40 | 2017-05-04 20:31:42 | System boot | 16
41 | 2017-05-04 20:31:42 | Last post code in previous boot | 0x73 | Device Resource Allocation
42 | 2017-05-04 20:31:42 | Chrome OS Developer Mode
43 | 2017-05-04 20:31:42 | Memory Cache Update | Variable | Success
44 | 2017-05-04 20:32:30 | System boot | 17
45 | 2017-05-04 20:32:30 | Chrome OS Developer Mode
46 | 2017-05-04 20:32:30 | Memory Cache Update | Variable | Success
47 | 2017-05-04 20:33:34 | Kernel Event | Clean Shutdown
48 | 2017-05-04 20:33:41 | System boot | 18
49 | 2017-05-04 20:33:41 | System Reset
50 | 2017-05-04 20:33:41 | Chrome OS Developer Mode
51 | 2017-05-04 20:33:42 | CPU Thermal Trip
52 | 2017-05-04 20:33:42 | ACPI Enter | S5
53 | 2000-00-00 00:00:08 | System boot | 19
54 | 2000-00-00 00:00:08 | Chrome OS Developer Mode
55 | 2000-00-00 00:00:08 | Memory Cache Update | Variable | Success
56 | 2017-05-04 20:36:22 | Kernel Event | Clean Shutdown
57 | 2017-05-04 20:36:28 | System boot | 20
58 | 2017-05-04 20:36:28 | System Reset
59 | 2017-05-04 20:36:28 | ACPI Wake | S5
60 | 2017-05-04 20:36:29 | Chrome OS Developer Mode
61 | 2017-05-04 20:36:29 | CPU Thermal Trip
62 | 2017-05-04 20:36:29 | ACPI Enter | S5
63 | 2017-05-04 20:36:38 | System boot | 21
64 | 2017-05-04 20:36:38 | Chrome OS Developer Mode
65 | 2017-05-04 20:36:38 | Memory Cache Update | Variable | Success

-- 
To view, visit https://review.coreboot.org/18946
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fd6058c03f32ff8edccd56ca2aa5359d9b21b1
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No