[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Add marco to define IOSTERM for GPIO c...
Lijian Zhao (Code Review)
gerrit at coreboot.org
Fri May 5 00:40:25 CEST 2017
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19576 )
Change subject: soc/intel/apollolake: Add marco to define IOSTERM for GPIO config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19576/1/src/soc/intel/apollolake/include/soc/gpio.h
File src/soc/intel/apollolake/include/soc/gpio.h:
Line 76: PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm)
> Can you please just call this one from PAD_CFG_NF_IOSSTATE and PAD_CFG_NF_I
Done
--
To view, visit https://review.coreboot.org/19576
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178f6d3055d4620cb3c895245c40f324383873ad
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Freddy Paul <freddy.paul at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list